Release v19.0.0#324
Closed
poljar wants to merge 3 commits into
Closed
Conversation
andybalaam
approved these changes
May 12, 2026
richvdh
requested changes
May 12, 2026
Comment on lines
+3
to
11
| # matrix-sdk-crypto-wasm v19.0.0 | ||
|
|
||
| - Update matrix-rust-sdk to `0.17.0`: | ||
|
|
||
| - Check the user ID in the `sender_device_keys` property of Olm-encrypted | ||
| to-device events to prevent sender spoofing by homeserver owners. | ||
| [#6553](https://github.com/matrix-org/matrix-rust-sdk/pull/6553) | ||
| - Update to vodozemac 0.10.0 making the `PkEncryption::encrypt` API fallible | ||
| [#6477](https://github.com/matrix-org/matrix-rust-sdk/pull/6477) |
Member
There was a problem hiding this comment.
Why the major version bump? If there are breaking changes, we should call them out in the changelog. If there aren't, we don't need a major version bump.
Contributor
Author
There was a problem hiding this comment.
We discussed this in chat.
The reason why I assumed a major version bump was required is because PkEncryption::encrypt method may throw an error now.
We don't consider this to be a breaking change, as such I'm going to close this and do a minor version bump instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.